Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Conversation

@JinShil
Copy link
Contributor

@JinShil JinShil commented Apr 4, 2019

This will remove the deprecation warning

src/core/simd.d(53): Deprecation: 32 byte vector types are only supported with -mcpu=avx

currently polluting druntime build output and facilitate advancement of the deprecation to an error.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @JinShil! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2541"

@wilzbach
Copy link
Contributor

wilzbach commented Apr 4, 2019

Awesome! We should soon follow with fixing this to use -de like we do for Phobos, so that we don't end up in this state for years again.

@dlang-bot dlang-bot merged commit 2a1f539 into dlang:master Apr 4, 2019
@JinShil JinShil deleted the version_32_byte_vector_types branch April 4, 2019 03:47
@JinShil
Copy link
Contributor Author

JinShil commented Apr 4, 2019

We should soon follow with fixing this to use -de

I would if I knew immediately where to put it.

@wilzbach
Copy link
Contributor

wilzbach commented Apr 4, 2019

#1982 (i.e. adding -de to DFLAGS)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants